<Swing Dev> [9] Review Request: 6832045 DefaultSynthStyle.{getStateInfo, getMatchCount) should use Integer.bitCount

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Fri Apr 8 12:59:16 UTC 2016


The fix looks good to me.

Thanks,
Alexandr.

On 08/04/16 16:01, Sergey Bylokhov wrote:
> Hello,
> Please review the small cleanup for jdk9.
>
> The code which was copied from BigInteger.bitCnt() replaced by 
> Integer.bitCount().
> Note that this code is removed from BigInteger class itself and also 
> replaced by Integer.bitCount [1].
>
> The getMatchCount() method is removed, because initially(long ago) it 
> was used in place which was changed in the fix. But now it is unused.
>
> [1] http://hg.openjdk.java.net/jdk9/client/jdk/rev/8d2efec31d78
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-6832045
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/6832045/webrev.00
>




More information about the swing-dev mailing list