<Swing Dev> Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

[Sergey Bylokhov]

Hi, Avik.
It seems there is one more bug in this "if".
Change the input source to "Hindi Dev.."/"Russian.." then this test 
fails anyway(it will produce the double action).
Moreover if I change the source input to Hindi Transliteration, the test 
sometimes crashed.
Please double check.

On 06.04.16 13:42, Avik Niyogi wrote:
> Hi All,
>
> Kindly review the bug fix for JDK 9.
>
> *Bug:*
> https://bugs.openjdk.java.net/browse/JDK-8152492
>
> *Webrev:*
> http://cr.openjdk.java.net/~aniyogi/8152492/webrev.00/
>
> *Issue:*
> For OSX, having there is provision of non-integrated menubar. for this
> case, triggering the menu action by key press triggered double action in
> some cases
>
> *Cause:*
> Due to the use of Shift modifier being a soft modifier in case of mac.
> For example “Shift + m” is actually “M” and “Shift + ,” is “<“ .
> So such cases can not be used as shortcuts. This needs to be accounted for.
> Also, cases where “Cmd + Shift + c” is used as a shortcut, it should not
> morph that to a “Cmd + C” command and should detect c itself.
> Also, “Shift + ↑” has no equivalent soft modification and can be taken
> as a shortcut. This has to be accounted for.
>
> *Fix:*
> All required edge case scenarios for the soft modification of Shift and
> cases of valid modifiers were taken into account.
>
> With Regards,
> Avik Niyogi


-- 
Best regards, Sergey.