<Swing Dev> [9] Review request for 8153276: [TEST_BUG] javax/swing/JFileChooser/ShellFolderQueries/ShellFolderQueriesTest.java

Semyon Sadetsky semyon.sadetsky at oracle.com
Thu Apr 14 07:05:17 UTC 2016


On 4/13/2016 9:57 PM, Philip Race wrote:
> Perhaps better but given the minimal use here can't we just
> replace it with 
> System.getProperty("os.name").toLowerCase().contains("windows") ?
>
> Then you neither need jtreg to run it, nor internal API.
I agree. See the updated webrev: 
http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.01/

--Semyon
>
> -phil.
>
> On 4/13/16, 11:44 AM, Sergey Bylokhov wrote:
>> +1
>>
>> On 13.04.16 17:17, Yuri Nesterenko wrote:
>>> Looks good to me.
>>>
>>> -yan
>>>
>>> On 04/13/2016 05:07 PM, Semyon Sadetsky wrote:
>>>> Hello,
>>>>
>>>> Please review fix for JDK9:
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8153276
>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8153276/webrev.00/
>>>>
>>>> Internal API usage sun.awt.OSInfo was replaced by 
>>>> jdk.testlibrary.OSInfo.
>>>>
>>>> --Semyon
>>>>
>>>
>>
>>




More information about the swing-dev mailing list