<Swing Dev> Review Request of 8152492: [macosx swing] double key event actions when using Mac menubar

[Sergey Bylokhov]

On 19.04.16 11:46, Avik Niyogi wrote:
> Hi All,
> Please review my code changes with inputs received:

Can you please add some description of your changes, it seems you 
removed all code which was added by you previously.

> http://cr.openjdk.java.net/~aniyogi/8152492/webrev.01/
>
> With Regards,
> Avik Niyogi
>> On 19-Apr-2016, at 11:47 am, Avik Niyogi <avik.niyogi at oracle.com
>> <mailto:avik.niyogi at oracle.com>> wrote:
>>
>> Hi Sergey,
>> I have tried all these Input sources:
>> <Screen Shot 2016-04-19 at 11.40.33 am.png>
>> I am unable to reproduce the test failure as mentioned by you with
>> these inputs. Please provide some screenshots and/or details of the
>> procedure used for this test failure.
>> Thank you in advance.
>>
>> With Regards,
>> Avik Niyogi
>>
>>> On 08-Apr-2016, at 8:15 pm, Sergey Bylokhov
>>> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>>
>>> Hi, Avik.
>>> It seems there is one more bug in this "if".
>>> Change the input source to "Hindi Dev.."/"Russian.." then this test
>>> fails anyway(it will produce the double action).
>>> Moreover if I change the source input to Hindi Transliteration, the
>>> test sometimes crashed.
>>> Please double check.
>>>
>>> On 06.04.16 13:42, Avik Niyogi wrote:
>>>> Hi All,
>>>>
>>>> Kindly review the bug fix for JDK 9.
>>>>
>>>> *Bug:*
>>>> https://bugs.openjdk.java.net/browse/JDK-8152492
>>>>
>>>> *Webrev:*
>>>> http://cr.openjdk.java.net/~aniyogi/8152492/webrev.00/
>>>>
>>>> *Issue:*
>>>> For OSX, having there is provision of non-integrated menubar. for this
>>>> case, triggering the menu action by key press triggered double action in
>>>> some cases
>>>>
>>>> *Cause:*
>>>> Due to the use of Shift modifier being a soft modifier in case of mac.
>>>> For example “Shift + m” is actually “M” and “Shift + ,” is “<“ .
>>>> So such cases can not be used as shortcuts. This needs to be
>>>> accounted for.
>>>> Also, cases where “Cmd + Shift + c” is used as a shortcut, it should not
>>>> morph that to a “Cmd + C” command and should detect c itself.
>>>> Also, “Shift + ↑” has no equivalent soft modification and can be taken
>>>> as a shortcut. This has to be accounted for.
>>>>
>>>> *Fix:*
>>>> All required edge case scenarios for the soft modification of Shift and
>>>> cases of valid modifiers were taken into account.
>>>>
>>>> With Regards,
>>>> Avik Niyogi
>>>
>>>
>>> --
>>> Best regards, Sergey.
>>
>


-- 
Best regards, Sergey.