<Swing Dev> [9] Review request for 8162856 JSlider thumb is twice smaller on HiDPI display

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Wed Aug 3 12:26:47 UTC 2016


On 02.08.16 18:01, Sergey Bylokhov wrote:
> Hi, Alex.
>  - Is it necessary to restore tha scale to the previous value?
>  - It seems that getIconWidth/getIconHeight can be used instead of 15
> and 16?
>  - Should we update other implementations of paintToImage() in other
> classes?

And related question: why the Graphics was not scaled when it was created.

>
> On 02.08.16 13:46, Alexandr Scherbatiy wrote:
>>
>> Hello,
>>
>> Could you review the fix:
>>   bug: https://bugs.openjdk.java.net/browse/JDK-8162856
>>   webrev: http://cr.openjdk.java.net/~alexsch/8162856/webrev.00
>>
>>   This is a regression from the fix: JDK-8143064 Icons are not properly
>> rendered with Windows L&F on HiDPI display
>> MetalIconFactory.OceanVerticalSliderThumbIcon/OceanHorizontalSliderThumbIcon.paintToImage(...)
>>
>> methods do not take the provided image size into account.
>>   The fix sets graphics scale when icon sizes are different from default.
>>
>>  Thanks,
>>  Alexandr.
>>
>>
>
>


-- 
Best regards, Sergey.



More information about the swing-dev mailing list