<Swing Dev> [9] Review Request: 8162970 Merge error in the DefaultRowSorter.java

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Thu Aug 4 13:02:15 UTC 2016


The fix looks good to me.

Thanks,
Alexandr.

On 8/2/2016 6:24 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk9.
>
> It seems that long time ago there was a merge error in the 
> DefaultRowSorter.java, which caused a duplication of one paragraph in 
> the specification:
>
>  * <p>
>  * If the underlying model structure changes (the
>  * <code>modelStructureChanged</code> method is invoked) the following
>  * are reset to their default values: <code>Comparator</code>s by
>  * column, current sort order, and whether each column is sortable. To
>  * find the default <code>Comparator</code>s, see the concrete
>  * implementation (for example, {@link
>  * javax.swing.table.TableRowSorter TableRowSorter}). The default
>  * sort order is unsorted (the same as the model), and columns are
>  * sortable by default.
>  * <p>
>  * If the underlying model structure changes (the
>  * <code>modelStructureChanged</code> method is invoked) the following
>  * are reset to their default values: <code>Comparator</code>s by column,
>  * current sort order and whether a column is sortable.
>  * <p>
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8162970
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8162970/webrev.00
>




More information about the swing-dev mailing list