<Swing Dev> Review Request for 8163261: regression on Linux: java/awt/LightweightDispatcher/LWDispatcherMemoryLeakTest.java

[Alexandr Scherbatiy]

On 8/15/2016 12:43 PM, Ambarish Rapte wrote:
>
> Hi,
>
>                 Please review fix for JDK9,
>
>                 Bug: https://bugs.openjdk.java.net/browse/JDK-8163261
>
>                 Webrev: 
> http://cr.openjdk.java.net/~arapte/8163261/webrev.00/ 
> <http://cr.openjdk.java.net/%7Earapte/8163261/webrev.00/>
>
> Issue:
>
>                 Reference to JButton was not getting collected by GC.
>
> Cause:
>
>                 A strong reference to objects was held by 
> PainterMultiResolutionCachedImage.
>
>                 And the image reference was held by HashMap.
>
> Fix:
>
>                 Changing the HashMap to WeakHashMap. Entry to 
> WeakHashMap gets removed after the object has no other strong reference.
>
     May be using the soft reference would be better in this case. It 
could be expensive to recreate a cache with images every time GC removed 
them.

   Thanks,
   Alexandr.
>
> Regards,
>
> Ambarish
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160817/155c4d21/attachment.html>