<Swing Dev> [9] Review request for 8164032 JViewport backing store image is not scaled on HiDPI display

[Alexandr Scherbatiy]

On 8/18/2016 3:05 PM, Alexandr Scherbatiy wrote:
>
> Hello,
>
> Could you review the updated fix:
>   http://cr.openjdk.java.net/~alexsch/8164032/webrev.02
>
>   The backing store image is recreated for the case where scaled sizes 
> are changed.

   A version where a VolatileImage is used as a backing store image:
     http://cr.openjdk.java.net/~alexsch/8164032/webrev.03/

   Thanks,
   Alexandr.
>
> Thanks,
> Alexandr.
>
> On 8/17/2016 5:05 PM, Sergey Bylokhov wrote:
>> On 17.08.16 14:02, Alexandr Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the updated fix:
>>>   http://cr.openjdk.java.net/~alexsch/8164032/webrev.01
>>>
>>> The generic transform is used for the backing store image scaling.
>>
>> As far as I understand the current fix will not work if the scale was 
>> changed(the JViewport will use old buffer)?
>>
>> It seems that the new local AbstractMultiResolutionImage contain only 
>> one image variant inside and looks quite similar to the 
>> VolatileImage, probably we can change this cache from BufferedImage 
>> to VolatileImage? In this case the scale of the VI will be the same 
>> as "g":
>> g.getDeviceConfiguration().createCompatibleVolatileImage()
>>
>>
>>> On 8/15/2016 4:58 PM, Sergey Bylokhov wrote:
>>>> Hi, Alexandr.
>>>> I doubt that getScaleX/getScaleY can be used here because the scale
>>>> can be generic(translate+rotate+scale). How this cache will work if
>>>> transform will be changed after we save "backingStoreImage"?
>>>>
>>>> On 15.08.16 16:16, Alexandr Scherbatiy wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>> Could you review the fix:
>>>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8164032
>>>>>   webrev: http://cr.openjdk.java.net/~alexsch/8164032/webrev.00
>>>>>
>>>>>   The fix scales the JViewport backing store image when graphics
>>>>> transform is not identity.
>>>>>
>>>>>  Thanks,
>>>>>  Alexandr.
>>>>>
>>>>
>>>>
>>>
>>
>>
>