<Swing Dev> 8138771: java.awt.image.AbstractMultiResolutionImage needs customized spec for methods of Image which it implements

[Alexandr Scherbatiy]

On 8/30/2016 12:17 PM, Avik Niyogi wrote:
> Hi All,
> Please review the proposed specification for JDK9 including inputs 
> from reviewer reviews.
>
> *http://cr.openjdk.java.net/~aniyogi/8138771/webrev.02/* 
> <http://cr.openjdk.java.net/%7Eaniyogi/8138771/webrev.02/>
>
   I believe the @return tag should have a simple description in other 
case the compilation fails because of enabled javadoc warning errors.

   Thanks,
   Alexandr.

> Thank you in advance.
>
> With Regards,
> Avik Niyogi
>
>> On 29-Aug-2016, at 5:55 pm, Alexandr Scherbatiy 
>> <alexandr.scherbatiy at oracle.com 
>> <mailto:alexandr.scherbatiy at oracle.com>> wrote:
>>
>> On 8/29/2016 9:52 AM, Avik Niyogi wrote:
>>> Hi All,
>>>
>>> Please review the proposed specification for JDK9 including inputs 
>>> from reviver reviews.
>>>
>>> *http://cr.openjdk.java.net/~aniyogi/8138771/webrev.01/ 
>>> <http://cr.openjdk.java.net/%7Eaniyogi/8138771/webrev.01/>*
>>>
>>   There is the {@inheritDoc} which allows to use a javadoc from the 
>> parent method.
>>   Javadoc for 
>> AbstractMultiResolutionImage.getWidth()/getHeight()/getSource()/getProperty() 
>> could be like:
>>
>>     /**
>>      * This method simply delegates to the {@code getBaseImage()}.
>>      * It is equivalent to: {@code getBaseImage().getWidth(observer)).
>>      *
>>      * @see #getBaseImage
>>      *
>>      * @since 9
>>      */
>>
>>   Thanks,
>>   Alexandr.
>>
>>> Thank you in advance.
>>>
>>> With Regards,
>>> Avik Niyogi
>>>
>>>> On 23-Aug-2016, at 2:58 pm, Alexander Scherbatiy 
>>>> <alexandr.scherbatiy at oracle.com 
>>>> <mailto:alexandr.scherbatiy at oracle.com>> wrote:
>>>>
>>>> On 22/08/16 11:06, Avik Niyogi wrote:
>>>>> + awt-dev
>>>>>
>>>>>
>>>>>> On 22-Aug-2016, at 12:28 pm, Avik Niyogi <avik.niyogi at oracle.com 
>>>>>> <mailto:avik.niyogi at oracle.com>> wrote:
>>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> Kindly review the proposed specifications for JDK9.
>>>>>>
>>>>>> *Bug: https://bugs.openjdk.java.net/browse/JDK-8138771*
>>>>>>
>>>>>> *Webrev: http://cr.openjdk.java.net/~aniyogi/8138771/webrev.00/ 
>>>>>> <http://cr.openjdk.java.net/%7Eaniyogi/8138771/webrev.00/>*
>>>>>>
>>>>>> *Issue: *The customised specifications necessitated for 
>>>>>> getGraphics method did not exist.
>>>>>>  So test cases created according to derived specifications would 
>>>>>> lead to test cases failures.
>>>>>>
>>>>>> *Cause: * No congruous specifications could elicit failure in 
>>>>>> circumstances not encompassed
>>>>>> in test cases generated without the knowledge of the same.
>>>>>>
>>>>>> *Fix:* Appropriate comprehensive specifications required were added.
>>>> -  I am not a native speaker. May be something like this would be 
>>>> better:
>>>> ------
>>>>     /**
>>>>      * This method is not supported by {@code 
>>>> AbstractMultiResolutionImage}
>>>>      * and always throws {@code UnsupportedOperationException}
>>>>      *
>>>>      * @return {@code UnsupportedOperationException} is thrown
>>>>      * @throws UnsupportedOperationException this method is not 
>>>> supported
>>>> ------
>>>>
>>>> - others overridden method should have a documentation that they 
>>>> delegate call to the base image (see #getBaseImage)
>>>>
>>>> Thanks,
>>>> Alexandr.
>>>>
>>>>>>
>>>>>> With Regards,
>>>>>> Avik Niyogi
>>>>>
>>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160830/418c0c9d/attachment.html>