<Swing Dev> [9] Review request for 8158411 Regression on Swingmark on 8u102 b03 comparing 8u102 b02 on several configs on win32

Semyon Sadetsky semyon.sadetsky at oracle.com
Wed Aug 31 14:35:16 UTC 2016


I saw that some Windows 10 apps may change scale without relogin. But 
probably they were created for UWP.

So, the fix looks good to me.

--Semyon


On 8/31/2016 4:08 PM, Philip Race wrote:
> IIRC that would require a system reboot on Window 7 and
> at least for you to log out and log back in on later OSes, so that is 
> not an issue is it ?
>
> +1
>
> -phil.
>
> On 8/31/16, 5:29 AM, Semyon Sadetsky wrote:
>> Hi Alexander,
>>
>> If the system scale is changed, will the skin size be updated 
>> according to the new dpi value?
>>
>> --Semyon
>>
>>
>> On 31.08.2016 15:08, Alexandr Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8158411
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8158411/webrev.00
>>>
>>>   This is a regression from the fix JDK-8076545 Text size is twice 
>>> bigger under Windows L&F on Win 8.1 with HiDPI display.
>>>
>>>   The system dpi is read every time when it is required. The fix 
>>> reads the system dpi only once.
>>>   Before the current fix SwingMark Sub-Menus test called 50 times 
>>> has score 37021. After the fix the score is 33890. Which gives 
>>> improvement (37021 - 33890) * 100 / 37021 = 8.45%.
>>>
>>>  Thanks,
>>>  Alexandr.
>>>
>>




More information about the swing-dev mailing list