<Swing Dev> [9] Review request for JDK-8159906: [TEST_BUG] javax/swing/JDialog/Transparency/TransparencyTest.java

[Prasanta Sadhukhan]

+1

Regards
Prasanta
On 12/5/2016 5:38 PM, Maksim Khramov wrote:
> Hello,
>
> webrev updated: http://cr.openjdk.java.net/~yan/8159906/webrev.01/ 
> <http://cr.openjdk.java.net/%7Eyan/8159906/webrev.01/>
>
> Added bugid
> DlgPos variable marked as volatile.
>
> Thanks,
> Maksim.
>
> On 02.12.2016 18:01, Prasanta Sadhukhan wrote:
>> You need to add 8159906 to @bug tag.
>>
>> Also, one more thing, since dlgPos is accessed from EDT and main 
>> thread shouldn't it be declared volatile?
>>
>> Rest looks fine.
>> Regards
>> Prasanta
>> On 12/2/2016 5:52 PM, Maksim Khramov wrote:
>>> Hello,
>>>
>>> please review this request...
>>>
>>> Webrev: http://cr.openjdk.java.net/~yan/8159906/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Eyan/8159906/webrev.00/>
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8159906
>>>
>>> Test bug. Windows transparency is not supported on Solaris. Test 
>>> just skip execution in that case
>>>
>>> Thanks,
>>> Maksim.
>>
>