<Swing Dev> [9] Review request for 8169922 SwingMark/TextArea: 2-7% regression on Linux, Mac, Windows in 9-b143

[Phil Race]

  821
822 static boolean getFPMethodOverriden(Class<?> cls, String method,
823 FPMethodArgs methodArgs) {
824 FPMethodItem methodItem = new FPMethodItem(cls, method); Where are 
the definitions of the types FPMethodItem and FPMethodArgs ?

842 methodArgs.getMethodAruments(false),
843 methodArgs.getMethodAruments(true));

getMethodAruments  ->getMethodArguments


-phil.

On 12/13/2016 07:41 AM, Alexandr Scherbatiy wrote:
>
> Hello,
>
> Could you review the fix:
>   bug: https://bugs.openjdk.java.net/browse/JDK-8169922
>   webrev: http://cr.openjdk.java.net/~alexsch/8169922/webrev.00
>
>   The fix JDK-8156217 checks presence of the overridden methods with 
> floating point arguments.
>   The proposed fix caches results of found overridden methods with 
> floating point arguments.
>
>   I run the SwingSet2 with the custom test which intensively creates 
> JTextField, JPasswordField, JTextArea, and JEditorPane.
>
>   The results of the test running with the following JDK are:
>   1. Methods with int arguments are always called without the methods 
> overridden check: 45822 // before the fix JDK-8156217
>   2. Methods with floating point arguments are always called without 
> the methods overridden check: 46175
>     performance decreasing: 100 * (46175 - 45822) / 45822 = 0.77%
>   3. Methods with floating point arguments are always called with the 
> methods overridden check: 48836 // fix JDK-8156217
>     performance decreasing: 100 * (48836 - 45822) / 45822 = 6.58%
>   4. Methods with floating point arguments are always called and the 
> methods overridden checks are cached: 46592 // current fix
>     performance decreasing: 100 * (46592 - 45822) / 45822 = 1.68%
>
>  Thanks,
>  Alexandr.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20161213/be3fbdc5/attachment.html>