<Swing Dev> [9] Review request for 8133919 [macosx] JTable grid lines are incorrectly positioned on HiDPI display

Sergey Bylokhov sergey.bylokhov at oracle.com
Tue Dec 20 13:45:14 UTC 2016


Looks fine.

> 
> Hello,
> 
> Could you review the updated fix:
>  http://cr.openjdk.java.net/~alexsch/8133919/webrev.01
> 
> The test is converted to the automated.
> 
> Thanks,
> Alexandr.
> 
> On 12/15/2016 1:24 PM, Sergey Bylokhov wrote:
>>> Could you review the fix:
>>>  bug: https://bugs.openjdk.java.net/browse/JDK-8133919
>>>  webrev: http://cr.openjdk.java.net/~alexsch/8133919/webrev.00
>>> 
>>>  Draw lines calls are replaced by SwingUtilities2.drawHLine()/drawVLine in BasicTableUI.
>>>  The added test is manual because the Robot takes low-resolution screen-shot so necessary artifacts can be hidden.
>>>  It will  be possible to make the test automated after the fix JDK-8162959 [HiDPI] screenshot artifacts using AWT Robot (see [1])
>> Probably it Is possible to automate it via drawing to the image in the paint() method?
>> 
> 




More information about the swing-dev mailing list