<Swing Dev> Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

[Ambarish Rapte]

Hi Prem,

                Thanks for updating the test, Fix looks fine to me.

 

 

Thanks,

Ambarish

 

From: Prem Balakrishnan 
Sent: Tuesday, February 02, 2016 4:31 PM
To: Ambarish Rapte; Alexander Scherbatiy; Semyon Sadetsky; Sergey Bylokhov; Rajeev Chamyal; swing-dev at openjdk.java.net; awt-dev at openjdk.java.net
Subject: RE: Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

 

Hi Ambarish,

 

Updated test .

Webrev: http://cr.openjdk.java.net/~arapte/prem/8062946/webrev.01/

 

Regards,
Prem

 

 

From: Ambarish Rapte 
Sent: Tuesday, February 02, 2016 2:47 PM
To: Alexander Scherbatiy; Prem Balakrishnan; Semyon Sadetsky; Sergey Bylokhov; Rajeev Chamyal; HYPERLINK "mailto:swing-dev at openjdk.java.net"swing-dev at openjdk.java.net; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: RE: Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

 

Hi Prem,

                The test passes without including the fix.

                The test should fail without fix, and should pass with fix.

 

Thanks,

Ambarish

 

From: Alexandr Scherbatiy 
Sent: Monday, February 01, 2016 5:15 PM
To: Prem Balakrishnan; Semyon Sadetsky; Sergey Bylokhov; Ambarish Rapte; Rajeev Chamyal; HYPERLINK "mailto:swing-dev at openjdk.java.net"swing-dev at openjdk.java.net; HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: Re: Review Request for 8062846 : Transparent JDialog will lose transparency upon iconify/deiconify sequence.

 


  The fix looks good to me.

  Thanks,
  Alexandr.

On 1/28/2016 9:45 PM, Prem Balakrishnan wrote:

Hi,

Please review fix for JDK9,

Bug: https://bugs.openjdk.java.net/browse/JDK-8062946 

Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Earapte/prem/8062946/webrev.00/"http://cr.openjdk.java.net/~arapte/prem/8062946/webrev.00/

 

Issue:

Transparent JDialog will lose transparency upon iconify/deiconify sequence.

 

Cause:

Regression: due to 6780496: Javaw process taking up 80-90 percent of CPU time!

https://bugs.openjdk.java.net/browse/JDK-6780496 

Intentionally when JDialog is iconified transparency is disabled, 

And transparency is not enabled when JDialog is deiconified.

 

Fix:

Transparency is enabled when JDialog is deiconified.

 

Regards,
Prem

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160203/92c74971/attachment.html>