<Swing Dev> Review Request of 8137169 : [macosx] Incorrect minimal heigh of JTabbedPane with more tabs

Alexander Potochkin alexander.potochkin at oracle.com
Thu Feb 25 13:15:23 UTC 2016


Hello Avik

AquaTruncatingTabbedPaneLayout has a lot of code which is specific for 
the AquaTabbedPaneUI.
I don't think setting the layout manager from the base class is the 
right solution here.

If there is a problem with minimum size it should be fixed inside the 
AquaTabbedPaneUI

Thanks
alexp

On 2/24/2016 12:07, Avik Niyogi wrote:
> Hi All,
>
> Kindly review the bug fix for JDK 9.
>
> *Bug:*
> https://bugs.openjdk.java.net/browse/JDK-8137169
>
> *Webrev:*
>
> http://cr.openjdk.java.net/~aniyogi/8137169/webrev.00/ 
> <http://cr.openjdk.java.net/%7Eaniyogi/8137169/webrev.00/>
>
> *Issue:*
> For Aqua Look&Feel, multiple calls to pane.getMinimumSize().height 
> causes incremental return of values.
>
> *Cause:*
> The impact was caused by a major broken code within 
> AquaTabbedPaneUI.java for createLayoutManager()
>
> *Fix:*
> Major linking calls to super class fix done within createLayoutManager().
>
> With Regards,
> Avik Niyogi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160225/e73b70d5/attachment.html>


More information about the swing-dev mailing list