<Swing Dev> Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

[Avik Niyogi]

Hi Alexander,

Due to animation effects on Aqua look and feel, the color checks can not be used as seen in the image below:

The Blue color is not homogeneously distributed and varies continuously. Since this is a fix for Aqua look and feel mainly, we need to perform a visual confirmation itself.
Hence, manual test is essential in this case.

With Regards,
Avik Niyogi

> On 11-Jan-2016, at 9:12 pm, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:
> 
> 
> Is it possible to make an automated test which compare colors from the 5/6 part of the progress bar
> when its value is set to 0 and 30? If these colors are the same it means that the progress has been painted on the left side instead of right.
> 
> Thanks,
> Alexandr.
>  
> 
> On 04/01/16 12:52, Avik Niyogi wrote:
>> Hi All,
>> 
>> Please review the webrev.01 :  <http://cr.openjdk.java.net/%7Eaniyogi/8016665/webrev.01/>http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/>
>> incorporated with the inputs received.
>> 
>> With Regards,
>> Avik Niyogi
>> 
>>> On 28-Dec-2015, at 10:23 am, Avik Niyogi <avik.niyogi at oracle.com <mailto:avik.niyogi at oracle.com>> wrote:
>>> 
>>> Hi Alexandr,
>>> 
>>> Automated test may fail based on folder contents on individual systems irrespective of the fix directly not depending on the same. 
>>> Also, to confirm this fix, it will need visual confirmation and hence, no automated test was provided.
>>> 
>>> With Regards,
>>> Avik Niyogi
>>>> On 23-Dec-2015, at 7:32 pm, Alexander Scherbatiy < <mailto:alexandr.scherbatiy at oracle.com>alexandr.scherbatiy at oracle.com <mailto:alexandr.scherbatiy at oracle.com>> wrote:
>>>> 
>>>> 
>>>> 
>>>>   The fix looks good to me.
>>>> 
>>>>   Is it possible to write an automated test for the fix?
>>>> 
>>>>   Thanks,
>>>>   Alexandr.
>>>> 
>>>> On 12/21/2015 2:55 PM, Avik Niyogi wrote:
>>>>> Hi All,
>>>>> 
>>>>> Kindly review the bug fix for JDK 9.
>>>>> 
>>>>> Bug:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8016665 <https://bugs.openjdk.java.net/browse/JDK-8016665>
>>>>> 
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~aniyogi/8016665/webrev.00/ <http://cr.openjdk.java.net/%7Eaniyogi/8016665/webrev.00/>
>>>>> 
>>>>> Issue:
>>>>> The manual test: Swing_AllComponents/Manual/I18nSwingTests
>>>>> in testsuite fails.
>>>>> 
>>>>> Cause:
>>>>> Due to not honouring of RIGHT_TO_LEFT parameter for setOrientation method applied for a JFileChooser for the AquaLookAndFeel only,
>>>>> the fileChooser does not get displayed in RIGHT_TO_LEFT orientation. 
>>>>> This issue was verified to exist only in AquaLookAndFeel for JFileChooser only due to wrong implementation in AquaFileSystemModel.
>>>>> Also, as provided in comments: "The Aqua LAF must support the RTL orientation of JFileChooser."
>>>>> 
>>>>> Fix:
>>>>> Added implementation for the check of RIGHT_TO_LEFT ComponentOrientation and verified with test suite.
>>>>> 
>>>>> 
>>>>> With Regards,
>>>>> Avik Niyogi
>>>> 
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160112/87434df0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PastedGraphic-1.tiff
Type: image/tiff
Size: 16906 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160112/87434df0/PastedGraphic-1.tiff>