<Swing Dev> Review request for 8015748: JProgressbar with Aqua LaF ignores JProgressbar#applyComponentOrientation(ComponentOrientation.RIGHT_TO_LEFT) call

[Avik Niyogi]

Hi All,

Please find the code changes in fix as with the inputs received for the same.
http://cr.openjdk.java.net/~aniyogi/8015748/webrev.02/ <http://cr.openjdk.java.net/~aniyogi/8015748/webrev.02/>

With Regards,
Avik Niyogi

> On 11-Jan-2016, at 3:55 pm, Semyon Sadetsky <semyon.sadetsky at oracle.com> wrote:
> 
> Hi Avik,
> 
> Shouldn't the graphics transformation be restored before the paintString() call?
> 
> It seems to me that left/right insets need to be swapped for right-to-left painting with mirroring graphics transformation.
> 
> --Semyon
> 
> On 1/5/2016 1:22 PM, Avik Niyogi wrote:
>> Hi All,
>> Please find webrev with inputs as provided:  <http://cr.openjdk.java.net/%7Eaniyogi/8015748/webrev.01/>http://cr.openjdk.java.net/~aniyogi/8015748/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8015748/webrev.01/>
>> With Regards,
>> Avik Niyogi
>> 
>>> On 23-Dec-2015, at 7:29 pm, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com <mailto:alexandr.scherbatiy at oracle.com>> wrote:
>>> 
>>> 
>>>   - please check that the progress bar string (progressBar.setString()/setStringPainted()) is painted correctly.
>>>   - is it possible to write an automated test for the fix?
>>> 
>>>   Thanks,
>>>   Alexandr.
>>> 
>>> On 12/21/2015 11:47 AM, Avik Niyogi wrote:
>>>> Hi All,
>>>> 
>>>> Kindly review the bug fix for JDK 9.
>>>> 
>>>> Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8015748 <https://bugs.openjdk.java.net/browse/JDK-8015748>
>>>> 
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~aniyogi/8015748/webrev.00/ <http://cr.openjdk.java.net/%7Eaniyogi/8015748/webrev.00/>
>>>> 
>>>> Issue:
>>>> The manual test: Swing_JProgressbar/Manual/ProgressBarLAFTests/ProgressBarLAFTest1
>>>>  in testsuite http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/7/swing <http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/7/swing> fails
>>>> 
>>>> Cause:
>>>> Due to not honouring of RIGHT_TO_LEFT parameter for setOrientation method applied for a JProgressBar for the AquaLookAndFeel only,
>>>> the progressBar does not have the ability to grow from right to left. This issue was verified to exist only in AquaLookAndFeel for JProgressBar.
>>>> 
>>>> Fix:
>>>> Added implementation for the check of RIGHT_TO_LEFT ComponentOrientation and verified with other combination orientation with available
>>>> Horizontal and Vertical orientations as provided from before.
>>>> 
>>>> With Regards,
>>>> Avik Niyogi
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160112/e2c4cbac/attachment.html>