<Swing Dev> Review request for 8016665: [macosx] JComponent behaviour doesn't comply API documentation (setComponentOrientation method), Aqua LAF

[Avik Niyogi]

Hi Sergey,
If fFileList refers to a soft linked empty folder, we will  will not need to apply orientation to it’s sub-components.

With Regards,
Avik Niyogi

> On 12-Jan-2016, at 7:19 pm, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hi, Avik.
> Is it possible that fFileList can be null? I see that in other places we do not check it to null?
> 
> On 04/01/16 11:52, Avik Niyogi wrote:
>> Hi All,
>> 
>> Please review the webrev.01 :
>> http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/ <http://cr.openjdk.java.net/~aniyogi/8016665/webrev.01/>
>> incorporated with the inputs received.
>> 
>> With Regards,
>> Avik Niyogi
>> 
>>> On 28-Dec-2015, at 10:23 am, Avik Niyogi <avik.niyogi at oracle.com <mailto:avik.niyogi at oracle.com>
>>> <mailto:avik.niyogi at oracle.com <mailto:avik.niyogi at oracle.com>>> wrote:
>>> 
>>> Hi Alexandr,
>>> 
>>> Automated test may fail based on folder contents on individual systems
>>> irrespective of the fix directly not depending on the same.
>>> Also, to confirm this fix, it will need visual confirmation and hence,
>>> no automated test was provided.
>>> 
>>> With Regards,
>>> Avik Niyogi
>>>> On 23-Dec-2015, at 7:32 pm, Alexander Scherbatiy
>>>> <alexandr.scherbatiy at oracle.com <mailto:alexandr.scherbatiy at oracle.com>
>>>> <mailto:alexandr.scherbatiy at oracle.com <mailto:alexandr.scherbatiy at oracle.com>>> wrote:
>>>> 
>>>> 
>>>> 
>>>>  The fix looks good to me.
>>>> 
>>>>  Is it possible to write an automated test for the fix?
>>>> 
>>>>  Thanks,
>>>>  Alexandr.
>>>> 
>>>> On 12/21/2015 2:55 PM, Avik Niyogi wrote:
>>>>> Hi All,
>>>>> 
>>>>> Kindly review the bug fix for JDK 9.
>>>>> 
>>>>> *Bug:*
>>>>> https://bugs.openjdk.java.net/browse/JDK-8016665 <https://bugs.openjdk.java.net/browse/JDK-8016665>
>>>>> 
>>>>> *Webrev:*
>>>>> http://cr.openjdk.java.net/~aniyogi/8016665/webrev.00/ <http://cr.openjdk.java.net/~aniyogi/8016665/webrev.00/>
>>>>> <http://cr.openjdk.java.net/%7Eaniyogi/8016665/webrev.00/ <http://cr.openjdk.java.net/%7Eaniyogi/8016665/webrev.00/>>
>>>>> 
>>>>> *Issue:*
>>>>> The manual test: Swing_AllComponents/Manual/I18nSwingTests
>>>>> in testsuite fails.
>>>>> 
>>>>> *Cause:*
>>>>> Due to not honouring of RIGHT_TO_LEFT parameter for setOrientation
>>>>> method applied for a JFileChooser for the AquaLookAndFeel only,
>>>>> the fileChooser does not get displayed in RIGHT_TO_LEFT orientation.
>>>>> This issue was verified to exist only in AquaLookAndFeel for
>>>>> JFileChooser only due to wrong implementation in AquaFileSystemModel.
>>>>> Also, as provided in comments: "The Aqua LAF must support the RTL
>>>>> orientation of JFileChooser."
>>>>> 
>>>>> *Fix:*
>>>>> Added implementation for the check of RIGHT_TO_LEFT
>>>>> ComponentOrientation and verified with test suite.
>>>>> 
>>>>> 
>>>>> With Regards,
>>>>> Avik Niyogi
>>>> 
>>> 
>> 
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160113/32db953e/attachment.html>