<Swing Dev> Review request for JDK-8139213 : Mac OS X Aqua Look and Feel: JOptionPane can truncate the first button.

Rajeev Chamyal rajeev.chamyal at oracle.com
Tue Jan 19 11:48:20 UTC 2016


Hello All,

Gentle reminder for review.

Regards,
Rajeev Chamyal

-----Original Message-----
From: Rajeev Chamyal 
Sent: 13 January 2016 16:37
To: Sergey Bylokhov; Alexander Scherbatiy; Prasanta Sadhukhan; swing-dev at openjdk.java.net
Subject: Review request for JDK-8139213 : Mac OS X Aqua Look and Feel: JOptionPane can truncate the first button.

Hello All,

Please review the following fix for Jdk9:

Bug : https://bugs.openjdk.java.net/browse/JDK-8139213
Webrev : http://cr.openjdk.java.net/~rchamyal/8139213/webrev.00/

Issue : In Mac OS X Aqua LAF JOptionPane truncates the first button if multiple buttons are added to it.

Cause: AquaButtonAreaLayout class is not overriding base class method minimumLayoutSize as a result it is not taking to account the default button width for Aqua LAF.
Hence it is calculating incorrect dimensions for JOptionPane which results in truncation of button.

Fix: Overriding minimumLayoutSize in AquaButtonAreaLayout to consider default button width and height while calculating minimum size for JOptionPane.

Regards,
Rajeev Chamyal



More information about the swing-dev mailing list