<Swing Dev> [9] Review Request for 8081722: Provide public API for file hierarchy provided by sun.awt.shell.ShellFolder

Semyon Sadetsky semyon.sadetsky at oracle.com
Tue Jan 19 12:15:18 UTC 2016


Hi Andrej,

The webrev is updated: 
http://cr.openjdk.java.net/~ssadetsky/8081722/webrev.04/

--Semyon

On 1/19/2016 2:28 PM, Andrej Golovnin wrote:
> Hi Semyon,
>
>> http://cr.openjdk.java.net/~ssadetsky/8081722/webrev.03/
>> get(String) is replaced with getChooserComboBoxFiles(). Other get() keys are
>> not in use by NetBeans.
> Please move the new methods after the constructor of the FileSystemView class.
>
> The description of the return value should not start with capital
> letter (affected lines 112, 126, 151), e.g.:
>
> 112      * @return An array of {@code File} objects.
>
> should be written as:
>
> 112      * @return an array of {@code File} objects.
>
>
> In the line 151 the javadoc tag @code is not used for null.
>
> Best regards,
> Andrej Golovnin




More information about the swing-dev mailing list