<Swing Dev> [9] Review request for 8160448: Make GTK3 menus appearence similar to native.

[Alexandr Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 7/1/2016 9:02 AM, Semyon Sadetsky wrote:
> On 6/30/2016 11:18 PM, Alexandr Scherbatiy wrote:
>
>> On 6/28/2016 7:12 PM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8160448
>>>
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8160448/webrev.00/
>>>
>>> GTK3 lib uses has several specific features in the menu painting 
>>> that differs from GTK2 approach. The solution implements those 
>>> features to follow the native menu appearance.
>>>
>>   219                 if (value != null && value instanceof Number) {
>>
>>   it looks like the check to the null can be omitted in this case.
> ok. Please review the corrected webrev 
> http://cr.openjdk.java.net/~ssadetsky/8160448/webrev.01/
>
> --Semyon
>>
>> Thanks,
>> Alexandr.
>>> Test would require native code, so noreg-hard label is used.
>>>
>>> --Semyon
>>>
>>
>