<Swing Dev> [9] Review request for 8058742: Text size is twice bigger under GTK L&F on Gnome with HiDPI enabled

[Alexandr Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 7/6/2016 10:03 PM, Semyon Sadetsky wrote:
> On 7/6/2016 6:03 PM, Alexandr Scherbatiy wrote:
>
>> On 7/6/2016 4:13 PM, Semyon Sadetsky wrote:
>>> Hello,
>>>
>>> Please review fix for JDK9:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8058742
>>>
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8058742/webrev.00/
>>
>>    - PangoFonts class is placed in the shared space and it uses the 
>> X11GraphicsDevice from the unix space. Could there be problems with 
>> build compilation on platforms differ from Unix?
> no it doesn't cause compilations problems. PangoFonts is used on Linux 
> platform only.
>>   - It is better to rename the scale field to nativeScale just to not 
>> mix it with other scale types
> ok.  webrev is updated: 
> http://cr.openjdk.java.net/~ssadetsky/8058742/webrev.01/
>>   - Does the test 
>> test/java/awt/font/FontScaling/FontScalingTest.java  fails without 
>> the proposed fix on Linux?
> Yes it fails before and passes after the fix.
>
> --Semyon
>>
>>   Thanks,
>>   Alexandr.
>>
>>>
>>> After adding hdpi support to JDK the GTK LnF fonts are scaled twice 
>>> using the JDK UI scale factor and the native scale factor derived 
>>> from the screen dpi setting.  The fix removes the native scale if it 
>>> is already taken into account in the JDK UI scale.
>>>
>>> --Semyon
>>>
>>
>