<Swing Dev> Swing Dev> Review Request JDK-8158205 HiDPI hand cursor broken on Windows

[Semyon Sadetsky]

+1

--Semyon


On 7/8/2016 10:49 AM, Alexandr Scherbatiy wrote:
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 7/8/2016 10:31 AM, Rajeev Chamyal wrote:
>>
>> Hello Alexandr,
>>
>> Please review the updated webrev.
>>
>> http://cr.openjdk.java.net/~rchamyal/8158205/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Erchamyal/8158205/webrev.01/>
>>
>> Test was always passing without fix also. I have converted it into 
>> manual test.
>>
>> Regards,
>>
>> Rajeev Chamyal
>>
>> *From:*Alexandr Scherbatiy
>> *Sent:* 05 July 2016 13:29
>> *To:* Rajeev Chamyal; swing-dev at openjdk.java.net; Sergey Bylokhov
>> *Subject:* Re: Swing Dev> Review Request JDK-8158205 HiDPI hand 
>> cursor broken on Windows
>>
>> On 7/5/2016 10:08 AM, Rajeev Chamyal wrote:
>>
>>     Hello All,
>>
>>     Please review the following fix.
>>
>>     Bug: https://bugs.openjdk.java.net/browse/JDK-8158205
>>
>>     Webrev: http://cr.openjdk.java.net/~rchamyal/8158205/webrev.00/
>>     <http://cr.openjdk.java.net/%7Erchamyal/8158205/webrev.00/>
>>
>>     Issue: Incorrect cursor type is displayed over frame in Hidpi screen.
>>
>>     Cause:  Windows getCursorPos API is returning scaled screen
>>     co-ordinates for mouse
>>
>>     as a result the findComponentAt is not able to find the frame
>>     below mouse pointer and its returning incorrect cursor type.
>>
>>     Fix: Updated awt_Cursor.cpp:: getCursorPos to return scaled down
>>     co-ordinates.
>>
>>
>>   - The call to JFrame methods should be done on EDT in the test.
>>   - It looks like there is no need to use the invokeLater() inside 
>> the invokeAndWait() call
>>   - In case the test fails the dispose method is never called.
>>
>>   Thanks,
>>   Alexandr.
>>
>>     Regards,
>>
>>     Rajeev Chamyal
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160708/cc6ef15a/attachment.html>