<Swing Dev> [9] Review request for 8160054: The FileChooser didn't displayed large font with GTK LAF option.

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Thu Jul 14 15:31:52 UTC 2016


On 6/27/2016 9:23 PM, Semyon Sadetsky wrote:
> Hello,
>
> Please review fix for JDK9:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8160054
>
> webrev: http://cr.openjdk.java.net/~ssadetsky/8160054/webrev.00/
>
> The root case is GTK LnF does not allow to change its default fonts.
>
> The proposed solution let's to use LnF font properties to change the 
> defaults.
  292         if (propFont != null && !font.equals(propFont)) {
  293             // if font property got different value then return it
  294             return propFont;
  295         }

   It looks like the !font.equals(propFont) condition is not necessary 
because when two fonts are equal it is right to return the propFont as well.

   Thanks,
   Alexandr.
>
> --Semyon
>
>




More information about the swing-dev mailing list