<Swing Dev> [9] Fix for JDK-7096375 : Swing ignores first click after decreasing system's time
Alexandr Scherbatiy
alexandr.scherbatiy at oracle.com
Tue Jul 19 09:03:08 UTC 2016
On 7/18/2016 3:27 PM, Ajit Ghaisas wrote:
> Hi,
>
> Bug :
> https://bugs.openjdk.java.net/browse/JDK-7096375
> Swing ignores first click after decreasing system's time.
>
> Fix :
> BasicButtonListener keeps track of the last time when a button is pressed.
> This is used while discarding mouse press events to handle multiClickThreshold.
> The condition to discard mouse press event is corrected.
>
> Webrev :
> http://cr.openjdk.java.net/~aghaisas/7096375/webrev.00/
>
> Request you to review.
The template used for the test is rather old. It is better to use
CountDownLatch for the manual test synchronization.
Could you rewrite the test using the TitledBorderTest as a sample:
http://hg.openjdk.java.net/jdk9/client/jdk/file/233b59b7ea2f/test/javax/swing/LookAndFeel/6439354/TitledBorderTest.java
There can be added two simple changes. The thread creation is not
necessary because the runnable can be directly executed by
SwingUtilities.invokeAndWait(). The timeout can be added to the
latch.await() call.
Thanks,
Alexandr.
>
> Regards,
> Ajit
More information about the swing-dev
mailing list