<Swing Dev> [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

Semyon Sadetsky semyon.sadetsky at oracle.com
Tue Jul 19 09:30:40 UTC 2016



On 19.07.2016 12:18, Alexandr Scherbatiy wrote:
> On 7/18/2016 11:46 AM, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8160087
>>
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8160087/webrev.00/
>>
>> A warning is added to avoid issues in user code to throw exceptions 
>> which were masked before. See bug descriptions for details.
>   Should this behavior (which exists for long time) be specified in 
> the DefaultRowSorter.convertRowIndexToView()/convertRowIndexToModel() 
> javadoc?
This was not a 
DefaultRowSorter.convertRowIndexToView()/convertRowIndexToModel() issue. 
It was a mistake in the FilePane class.
RowSorter's javadoc mentions the correct way to use it:

The view invokes a model change method when the underlying model has 
changed. There may be order dependencies in how the events are 
delivered, so a RowSorter should not update its mapping until one of 
these methods is invoked.

--Semyon
>
>   Thanks,
>   Alexandr.
>>
>> --Semyon
>>
>




More information about the swing-dev mailing list