<Swing Dev> RfR JDK-8161483 Implement AccessibleAction interface in JList.AccessibleJList.AccessibleJListChild

[Alexandr Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 7/19/2016 8:50 PM, Pete Brunet wrote:
> Look at .02 instead.  I had an extraneous println left in .01.
> http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.02/
>
> On 7/19/16 11:48 AM, Pete Brunet wrote:
>> I added a regression test:
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.01/
>>
>> Could someone please review that?
>>
>> I also need one more +1 on the code change.
>>
>> TiA, Pete
>>
>> On 7/19/16 3:17 AM, Alexandr Scherbatiy wrote:
>>>
>>> The fix looks good to me.
>>>
>>> Thanks,
>>> Alexandr.
>>>
>>> On 7/19/2016 5:10 AM, Pete Brunet wrote:
>>>> Please review the following:
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8161483
>>>> Patch: http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.00/
>>>>
>>>> This is a followon to the patch for
>>>> JDK-8145207 [macosx] JList, VO can't access non-visible list items
>>>>
>>>> In order to fixJDK-8145207the AccessibleAction interface was needed 
>>>> for JList.AccessibleJList.AccessibleJListChild but a backport of 
>>>> this fix has been requested and the released public API can not be 
>>>> changed in 8u or earlier.  The workaround for JDK-8145207 is to 
>>>> create and use a private subclass of 
>>>> JList.AccessibleJList.AccessibleJListChild, 
>>>> JList.AccessibleJList.ActionableAccessibleJListChild. The downside 
>>>> of this fix is that it returns a subclass of the 
>>>> JList.AccessibleJList.AccessibleJListChild.  If a user overrides 
>>>> the class and returns from its code it will not inherit the 
>>>> AccessibleAction behavior. For JDK 9 the 
>>>> ActionableAccessibleJListChild subclass should be removed and the 
>>>> AccessibleAction implementation moved to 
>>>> JList.AccessibleJList.AccessibleJListChild.
>>>>
>>>> TiA,
>>>> Pete 
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160719/2010c54f/attachment.html>