<Swing Dev> [9] Review request for 8160087: Change IOOBE to warning in the scenarios when it had not being thrown before the JDK-8078514

[Semyon Sadetsky]

On 7/20/2016 2:29 PM, Alexandr Scherbatiy wrote:
> On 7/20/2016 10:18 AM, Semyon Sadetsky wrote:
>> On 7/19/2016 4:06 PM, Alexandr Scherbatiy wrote:
>>
>>> On 7/19/2016 2:56 PM, Semyon Sadetsky wrote:
>>>> On 19.07.2016 14:20, Alexandr Scherbatiy wrote:
>>>>>
>>>>> The fix prints the warning method in case of wrong row sorter 
>>>>> usage. How often this can happen? Could the large number of the 
>>>>> messages overflow a user output?
>>>> In the FilePane this happened only once after the initial file list 
>>>> loading.
>>>    I am just worrying that in a user application which does not 
>>> properly use the row sorter there can be a lot of such warnings. And 
>>> it could be some library which he can't be able to update. Is it 
>>> possible to show the warning only once?
>> Yes. See the updated webrev: 
>> http://cr.openjdk.java.net/~ssadetsky/8160087/webrev.01/
>    A property which should be used by users needs to have the CCC 
> request.
It is added on the off-chance. It doesn't merit to be a documented property.

--Semyon
>    I believe that printing the warning message only once is enough.
>
>   Thanks,
>   Alexandr.
>>
>> --Semyon
>>>
>>>   Thanks,
>>>   Alexandr.
>>>
>>>>
>>>> --Semyon
>>>>>
>>>>> Thanks,
>>>>> Alexandr.
>>>>>
>>>>> On 7/19/2016 12:30 PM, Semyon Sadetsky wrote:
>>>>>>
>>>>>>
>>>>>> On 19.07.2016 12:18, Alexandr Scherbatiy wrote:
>>>>>>> On 7/18/2016 11:46 AM, Semyon Sadetsky wrote:
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> Please review fix for JDK9:
>>>>>>>>
>>>>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8160087
>>>>>>>>
>>>>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8160087/webrev.00/
>>>>>>>>
>>>>>>>> A warning is added to avoid issues in user code to throw 
>>>>>>>> exceptions which were masked before. See bug descriptions for 
>>>>>>>> details.
>>>>>>>   Should this behavior (which exists for long time) be specified 
>>>>>>> in the 
>>>>>>> DefaultRowSorter.convertRowIndexToView()/convertRowIndexToModel() 
>>>>>>> javadoc?
>>>>>> This was not a 
>>>>>> DefaultRowSorter.convertRowIndexToView()/convertRowIndexToModel() 
>>>>>> issue. It was a mistake in the FilePane class.
>>>>>> RowSorter's javadoc mentions the correct way to use it:
>>>>>>
>>>>>> The view invokes a model change method when the underlying model 
>>>>>> has changed. There may be order dependencies in how the events 
>>>>>> are delivered, so a RowSorter should not update its mapping until 
>>>>>> one of these methods is invoked.
>>>>>>
>>>>>> --Semyon
>>>>>>>
>>>>>>>   Thanks,
>>>>>>>   Alexandr.
>>>>>>>>
>>>>>>>> --Semyon
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>