<Swing Dev> [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

Semyon Sadetsky semyon.sadetsky at oracle.com
Wed Jun 1 09:30:31 UTC 2016


Hi,

The fix looks good.

In the test you could use File.createTempFile() or better 
Files.createTempFile()

--Semyon

On 6/1/2016 12:21 PM, Rajeev Chamyal wrote:
>
> Hello All,
>
> Please review the following webrev.
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8146319
>
> Webrev : http://cr.openjdk.java.net/~rchamyal/8146319/webrev.00/ 
> <http://cr.openjdk.java.net/%7Erchamyal/8146319/webrev.00/>
>
> Issue: JEditorPane::read method is not closing the InputStreamReader.
>
> Fix: closing the InputStreamReader in finally block.
>
> Regards,
>
> Rajeev Chamyal
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160601/e9b1f165/attachment.html>


More information about the swing-dev mailing list