<Swing Dev> [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

[Rajeev Chamyal]

Hello Semyon,

 

Thanks for the review. Please review the updated webrev.

http://cr.openjdk.java.net/~rchamyal/8146319/webrev.01/

 

Update: Updated test to use File.createTempFile() for creating temp file.

 

Regards,

Rajeev Chamyal

 

From: Semyon Sadetsky 
Sent: 01 June 2016 15:01
To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov; swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

 

Hi,

The fix looks good.

In the test you could use File.createTempFile() or better Files.createTempFile() 

--Semyon

On 6/1/2016 12:21 PM, Rajeev Chamyal wrote:

Hello All,

 

Please review the following webrev.

Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 

Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Erchamyal/8146319/webrev.00/"http://cr.openjdk.java.net/~rchamyal/8146319/webrev.00/ 

 

Issue: JEditorPane::read method is not closing the InputStreamReader.

Fix: closing the InputStreamReader in finally block.

 

Regards,

Rajeev Chamyal

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160601/b54d0be2/attachment.html>