<Swing Dev> Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

Alexandr Scherbatiy alexandr.scherbatiy at oracle.com
Wed Jun 1 19:28:02 UTC 2016


The fix looks good to me.

Thanks,
Alexandr.

On 5/31/2016 10:58 AM, Avik Niyogi wrote:
> Hi All,
> Please review the code changes with inputs provided.
>
> http://cr.openjdk.java.net/~aniyogi/8132771/webrev.01/ 
> <http://cr.openjdk.java.net/%7Eaniyogi/8132771/webrev.01/>
>
> With Regards,
> Avik Niyogi
>
>> On 31-May-2016, at 1:24 pm, Rajeev Chamyal <rajeev.chamyal at oracle.com 
>> <mailto:rajeev.chamyal at oracle.com>> wrote:
>>
>> Hello Avik,
>> The frame should be disposed in case of exception also.
>> Regards,
>> Rajeev Chamyal
>> *From:*Avik Niyogi
>> *Sent:*31 May 2016 11:14
>> *To:*Rajeev Chamyal; Alexander Scherbatiy; swing-dev at openjdk.java.net 
>> <mailto:swing-dev at openjdk.java.net>
>> *Subject:*<Swing Dev> Review request for 8132771: [TEST_BUG][macosx] 
>> Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX
>> Hi All,
>> Kindly review the fix for JDK9.
>> *Bug*: https://bugs.openjdk.java.net/browse/JDK-8132771
>> *Webrev*: http://cr.openjdk.java.net/~aniyogi/8132771/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eaniyogi/8132771/webrev.00/>
>> *Issue*: LastNodeLowerHalfDrop Test case throws an exception when the 
>> behaviour is as expected.
>> *Cause*: The robot does not have enough delay to run appropriately.
>> *Fix*: The test case was fixed to have enough delay for the test case.
>> With Regards,
>> Avik Niyogi
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160601/3f1abf36/attachment.html>


More information about the swing-dev mailing list