<Swing Dev> [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

[Rajeev Chamyal]

Hello Alexandr,

 

Please review the updated webrev.

 

http://cr.openjdk.java.net/~rchamyal/8146319/webrev.02/

Update: Updated code to use  try with resources.

 

Regards,

Rajeev Chamyal

 

From: Alexandr Scherbatiy 
Sent: 01 June 2016 19:30
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev at openjdk.java.net
Subject: Re: <Swing Dev> [9] Review request for JDK-8146319 JEditorPane function setPage leaves a file lock

 

On 6/1/2016 12:21 PM, Rajeev Chamyal wrote:



Hello All,

 

Please review the following webrev.

Bug : https://bugs.openjdk.java.net/browse/JDK-8146319 

Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Erchamyal/8146319/webrev.00/"http://cr.openjdk.java.net/~rchamyal/8146319/webrev.00/ 

 

Issue: JEditorPane::read method is not closing the InputStreamReader.

Fix: closing the InputStreamReader in finally block.

  Is it possible to use try-with-resources statement for the reader?

   Thanks,
   Alexandr. 

 

Regards,

Rajeev Chamyal

 

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160602/85787326/attachment.html>