<Swing Dev> [9] Review request for 8158734 JEditorPane.createEditorKitForContentType throws NPE after 6882559

Alexander Potochkin alexander.potochkin at oracle.com
Wed Jun 8 12:16:00 UTC 2016


Hello Mikhail

This version looks good to me

Thanks
alexp

> Hi Sergey,
>
> you are right, it's easier to check classloader for null before to add 
> it to hashtable:
> http://cr.openjdk.java.net/~mcherkas/8158734/9/webrev.01/src/java.desktop/share/classes/javax/swing/JEditorPane.java.udiff.html 
>
>
> On 6/7/2016 10:51 PM, Sergey Bylokhov wrote:
>> HI, Mikhail.
>> Can you please clarify the reason of usage Optional here if the 
>> optional itself can be null?
>>
>> On 07.06.16 22:05, mikhail cherkasov wrote:
>>> Hello,
>>>
>>> Could you please review the fix for:
>>> https://bugs.openjdk.java.net/browse/JDK-8158734
>>>  webrev: http://cr.openjdk.java.net/~mcherkas/8158734/9/webrev.00/
>>>
>>> A simple null check was added.
>>>
>>> Thanks,
>>> Mikhail.
>>>
>>>
>>
>>
>




More information about the swing-dev mailing list