<Swing Dev> [9] Review request for 8158734 JEditorPane.createEditorKitForContentType throws NPE after 6882559

[Alexey Ivanov]

Hi Mikhail, Sergey,

On 08.06.2016 17:43, Sergey Bylokhov wrote:
> On 08.06.16 17:31, mikhail cherkasov wrote:
>> And one more change: cr.openjdk.java.net/~mcherkas/8158734/9/webrev.02
>> I added a removing of old class loader if a new is null.
>
> Why it should be removed? I am not sure but is the null classloader is 
> a bootclassloader?

I think it should. Consider the following code:

registerEditorKitForContentType("test/test", "com.oracle.Test", 
<non-null-customized-classLoader>);

registerEditorKitForContentType("test/test", "com.sun.Test", null);

If the classloader is not removed from KitLoaderRegistry, then class 
"com.sun.Test" would be loaded using the wrong class loader which was 
set for class "com.oracle.Test".


In the test, you should create JEditorPane on EDT.


Regards,
Alexey

>
>>
>> On 6/8/2016 3:16 PM, Alexander Potochkin wrote:
>>> Hello Mikhail
>>>
>>> This version looks good to me
>>>
>>> Thanks
>>> alexp
>>>
>>>> Hi Sergey,
>>>>
>>>> you are right, it's easier to check classloader for null before to
>>>> add it to hashtable:
>>>> http://cr.openjdk.java.net/~mcherkas/8158734/9/webrev.01/src/java.desktop/share/classes/javax/swing/JEditorPane.java.udiff.html 
>>>>
>>>>
>>>>
>>>> On 6/7/2016 10:51 PM, Sergey Bylokhov wrote:
>>>>> HI, Mikhail.
>>>>> Can you please clarify the reason of usage Optional here if the
>>>>> optional itself can be null?
>>>>>
>>>>> On 07.06.16 22:05, mikhail cherkasov wrote:
>>>>>> Hello,
>>>>>>
>>>>>> Could you please review the fix for:
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8158734
>>>>>>  webrev: http://cr.openjdk.java.net/~mcherkas/8158734/9/webrev.00/
>>>>>>
>>>>>> A simple null check was added.
>>>>>>
>>>>>> Thanks,
>>>>>> Mikhail.
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>
>