<Swing Dev> [9] Review request for JDK-8159135 [PIT] javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue Jun 14 14:32:17 UTC 2016


The fix looks good to me.

Thanks,
Alexandr.

On 13/06/16 10:37, Rajeev Chamyal wrote:
>
> Hello Alexandr,
>
> Please review the updated webrev.
>
> http://cr.openjdk.java.net/~rchamyal/8159135/webrev.01/ 
> <http://cr.openjdk.java.net/%7Erchamyal/8159135/webrev.01/>
>
> Regards,
>
> Rajeev Chamyal
>
> *From:*Alexandr Scherbatiy
> *Sent:* 10 June 2016 19:52
> *To:* Rajeev Chamyal; Sergey Bylokhov; swing-dev at openjdk.java.net
> *Subject:* Re: <Swing Dev> [9] Review request for JDK-8159135 [PIT] 
> javax/swing/JMenuItem/8152981/MenuItemIconTest.java always fail
>
>
> On 6/10/2016 12:36 PM, Rajeev Chamyal wrote:
>
>     Hello All,
>
>     Please review the following fix.
>
>     Bug : https://bugs.openjdk.java.net/browse/JDK-8159135
>
>     Webrev : http://cr.openjdk.java.net/~rchamyal/8159135/webrev.00/
>     <http://cr.openjdk.java.net/%7Erchamyal/8159135/webrev.00/>
>
>     Issue : MenuItemIconTest fails on windows 10.
>
>     Cause : In windows 10  menu bar color is white and test checks for
>     red color only.
>
>     Fix: checking for other color values(green and blue) also.
>
>     Is it possible to compare color using equals method like other 
> objects:   Color.RED.equals(c)?
>
>    Thanks,
>    Alexandr.
>
>     Regards,
>
>     Rajeev Chamyal
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160614/107763c2/attachment.html>


More information about the swing-dev mailing list