<Swing Dev> [9] RFR JDK-8159068:The rendering of JTable is broken

[Alexandr Scherbatiy]

On 6/20/2016 8:10 AM, prasanta sadhukhan wrote:
>
> Gentle reminder for review!!
>
> Regards
> Prasanta
> On 6/13/2016 4:31 PM, prasanta sadhukhan wrote:
>> On 6/13/2016 12:51 PM, prasanta sadhukhan wrote:
>>> Hi All,
>>>
>>> Please review a fix for jdk9 where it was seen that if we try to 
>>> select some rows in a JTable, the text painted in the rows goes 
>>> missing.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8159068
>>>
>>> webrev: http://cr.openjdk.java.net/~psadhukhan/8159068/webrev.00/
>>>
>>> The issue was rMax value was decremented wrongly so when 
>>> paintCells() is called with wrong rMax, some rows were not printed 
>>> correctly.
>>>
>>> Fix is to make sure rmax is decremented properly, only when we are 
>>> trying to print whole visible portion of JTable and NOT when some 
>>> rows are being painted.

   Could you give two samples how this algorithm work. One sample where 
a whole visible portion of a JTable and another where some rows are 
being printed. What are rMax and  rMin values in both cases and how are 
they calculated?

   Thanks,
   Alexandr.

>>>
>>> Regarding the regression testcase, I could not make it automated as 
>>> the failure happens on random iteration.
>>> and also, getting selection background/foreground was giving same 
>>> values with and without the missing text.
>>>
>> Also, since it is a regression of 8081491 
>> <https://bugs.openjdk.java.net/browse/JDK-8081491>, it's testcase are 
>> working fine with this fix and so did SwingSet2 JTable demo.
>>> Regards
>>> Prasanat
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160621/af2daca1/attachment.html>