<Swing Dev> [9] Review request for 8160248 Dragged internal frame leaves artifacts for floating point ui scale

[Semyon Sadetsky]

On 6/27/2016 1:14 PM, Alexander Scherbatiy wrote:

> On 24/06/16 15:56, Semyon Sadetsky wrote:
>> Hi Alexander,
>>
>> Test fails on my local Ubuntu 14 because the image grabs shadow from 
>> the left border of the frame.
>>
>> Probably this is a test issue and you need to shift image window to 
>> the left by 1px.
>   This issue is reproduced with ui scale 2 and is not reproduced with 
> ui scale 1.
>     I created an issue on it: JDK-8160332 Robot.createScreenCapture() 
> image borders have artifacts for ui scale 2
>       https://bugs.openjdk.java.net/browse/JDK-8160332
Okay. Looks good to me.

--Semyon
>
>   Thanks,
>   Alexandr.
>>
>> --Semyon
>>
>>
>> On 6/24/2016 2:27 PM, Alexandr Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8160248
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8160248/webrev.00
>>>
>>>   SunGraphics2D.hitClip() does not guarantee that it returns false 
>>> for non-intersected areas.
>>>   This exactly happens for rectangles when floating point scale is 
>>> used. See discussion:
>>> http://mail.openjdk.java.net/pipermail/2d-dev/2016-June/007076.html
>>>
>>>   The proposed fix directly checks the graphics clip and component 
>>> bounds intersection.
>>>
>>>  Thanks,
>>>  Alexandr.
>>
>