<Swing Dev> Review Request JDK-8159152 Ctrl+F6, Ctrl+F5 doesn't work for iconified InternalFrame
Prasanta Sadhukhan
prasanta.sadhukhan at oracle.com
Wed Jun 29 08:54:37 UTC 2016
+1
Regards
Prasanta
On 6/22/2016 6:04 PM, Alexandr Scherbatiy wrote:
> The fix looks good to me.
>
> Thanks,
> Alexandr.
>
> On 6/22/2016 2:46 PM, Rajeev Chamyal wrote:
>>
>> Hello Alexandr,
>>
>> Thanks for the review. JDK-4878528
>> <https://bugs.openjdk.java.net/browse/JDK-4878528> keyboard focus
>> test was failing with current fix.
>>
>> I have updated the webrev to handle keyboard focus scenario. I have
>> executed all the regression tests for JInternalFrame all are passing.
>>
>> http://cr.openjdk.java.net/~rchamyal/8159152/webrev.01/
>>
>> Regards,
>>
>> Rajeev Chamyal
>>
>> *From:*Alexandr Scherbatiy
>> *Sent:* 21 June 2016 16:48
>> *To:* Rajeev Chamyal; Sergey Bylokhov; swing-dev at openjdk.java.net
>> *Subject:* Re: <Swing Dev> Review Request JDK-8159152 Ctrl+F6,
>> Ctrl+F5 doesn't work for iconified InternalFrame
>>
>> On 6/20/2016 5:59 AM, Rajeev Chamyal wrote:
>>
>> Hello Alexandr,
>>
>> TestJInternalFrameMinimize test passes after this fix.
>>
>> Could you also check that the initial issue where the call
>> setComponentOrderCheckingEnabled(true/false) has been added to the
>> DefaultDesktopManager.iconifyFrame(JInternalFrame) method?
>> JDK-6325652 Iconified JInternalFrame does not restore when
>> Ctrl+F5 is used
>> https://bugs.openjdk.java.net/browse/JDK-6325652
>>
>> Thanks,
>> Alexandr.
>>
>>
>> Regards,
>>
>> Rajeev Chamyal
>>
>> *From:*Alexandr Scherbatiy
>> *Sent:* 17 June 2016 18:35
>> *To:* Rajeev Chamyal; Sergey Bylokhov; swing-dev at openjdk.java.net
>> *Subject:* Re: <Swing Dev> Review Request JDK-8159152 Ctrl+F6,
>> Ctrl+F5 doesn't work for iconified InternalFrame
>>
>> On 6/17/2016 10:09 AM, Rajeev Chamyal wrote:
>>
>>
>> Hello All,
>>
>> Please review the following webrev.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8159152
>>
>> Webrev:
>> http://cr.openjdk.java.net/~rchamyal/8159152/webrev.00/
>> <http://cr.openjdk.java.net/%7Erchamyal/8159152/webrev.00/>
>>
>> Issue: Internal frame cache is not getting updated properly
>> on iconifyFrame if there are less than 3 frames on the desktop.
>>
>> Fix: Updated the iconifyFrame method so that frame cache
>> updates properly on internal frame remove and icon addition
>> to desktop.
>>
>>
>> Could you check that the test
>> test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
>> passes after the fix?
>>
>> Thanks,
>> Alexandr.
>>
>>
>>
>> Regards,
>>
>> Rajeev Chamyal
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160629/7e6526d4/attachment.html>
More information about the swing-dev
mailing list