<Swing Dev> Review Request of 8151282: [TEST_BUG] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails with GTK LnF
Avik Niyogi
avik.niyogi at oracle.com
Mon Mar 14 05:23:39 UTC 2016
Hi Sergey,
Seems like it is a delay issue. Will submit test case with a waitForIdle() fix.
With Regards,
Avik Niyogi
> On 10-Mar-2016, at 7:22 pm, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
>
> Hi, Avik.
> A few questions.
> - Why webrev contains the new file?
> - You marked the test as a mac specific but it is iterates over a bunch of l&fs. It seems it should not be OS specific, but should check some specific l&fs (which support such icons): Metal, Nimbus, Aqua, Windows(???). So gtk/motif should be skipped.
>
> On 08.03.16 8:10, Avik Niyogi wrote:
>> Hi All,
>>
>> Kindly review the bug fix for JDK 9.
>>
>> *Bug:*
>>
>> https://bugs.openjdk.java.net/browse/JDK-8151282
>>
>> *Webrev:*
>>
>> _http://cr.openjdk.java.net/~aniyogi/8151282/webrev.00/_
>> _
>> _
>> *Issue:*
>> The test case failed for GTK LAF.
>>
>> *Cause:*
>> The test case was meant to be Mac specific and was missing a jtreg parameter
>>
>> *Fix:*
>> Minor change to test case with @requires tag added to set the fix.
>>
>> With Regards,
>> Avik Niyogi
>
>
> --
> Best regards, Sergey.
More information about the swing-dev
mailing list