<Swing Dev> [9] Review request for 8149631: rgb(...) CSS color values are not parsed properly

Semyon Sadetsky semyon.sadetsky at oracle.com
Mon Mar 14 11:29:06 UTC 2016


Hello,

Please review fix for JDK9:

bug: https://bugs.openjdk.java.net/browse/JDK-8149631
webrev: http://cr.openjdk.java.net/~ssadetsky/8149631/webrev.00/

The issue is a regression of 4419748 which added support for border 
sides but it parse the rgb(...) color values wrong. Also before 4419748 
the parenthesis notations worked only for CSS attribute that is not 
expected to contain several values. The reason is splitting the 
multi-value CSS attribute (for example, "background: rgb(0, 0, 0) url( 
'b.gif' ) no-repeat;") using space divider didn't take into account that 
spaces within parenthesis should not be used as top-level dividers.
Fixing the value splitting should correct the situation for (...) 
entries in all multi-value CSS attributes.

--Semyon



More information about the swing-dev mailing list