<Swing Dev> Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

[Alexander Scherbatiy]

The fix looks good to me.

Just a small note: it is better to remove comment "527         //" since 
it does not have a description.

Thanks,
Alexandr.

On 17/03/16 17:21, Avik Niyogi wrote:
> It can be made into a class method, but herein this case it is needed 
> for that instance only and hence the need for instance method and 
> referred with “self”.
>
> With Regards,
> Avik Niyogi
>> On 16-Mar-2016, at 11:55 pm, Alexander Scherbatiy 
>> <alexandr.scherbatiy at oracle.com 
>> <mailto:alexandr.scherbatiy at oracle.com>> wrote:
>>
>>
>> Could the -(NSMutableString *) parseString: method be declared as 
>> class method instead of instance?
>>
>> Thanks,
>> Alexandr.
>>
>> On 14/03/16 17:18, Sergey Bylokhov wrote:
>>> Hi, Avik.
>>> Can you please take a look to these two tests before fixing this bug:
>>>
>>> TEST: javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java
>>> --------------------------------------------------
>>> TEST: 
>>> javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java
>>>
>>> I remember they passed on jdk8, but it seems we have a regression in 
>>> jdk9 and both of them fail.
>>>
>>> On 14.03.16 8:05, Avik Niyogi wrote:
>>>> Hi All,
>>>> A gentle reminder, please review my code changes.
>>>>
>>>> With Regards,
>>>> Avik Niyogi
>>>>> On 08-Mar-2016, at 9:39 pm, Avik Niyogi <avik.niyogi at oracle.com
>>>>> <mailto:avik.niyogi at oracle.com>> wrote:
>>>>>
>>>>> Hi All,
>>>>>
>>>>> Kindly review the bug fix for JDK 9.
>>>>>
>>>>> *Bug:*
>>>>>
>>>>> _https://bugs.openjdk.java.net/browse/JDK-8148555_
>>>>> _
>>>>> _
>>>>> *Webrev:*
>>>>>
>>>>> _http://cr.openjdk.java.net/~aniyogi/8148555/webrev.00/_
>>>>>
>>>>> *Issue:*
>>>>> Emoji selection in Character Viewer was causing exception in JNI
>>>>>
>>>>> *Cause:*
>>>>> Emojis are considered to be of different class type (namely,
>>>>> NSConcreteMutableAttributedString) from NSString which other
>>>>> characters are because of a surrogate pair for them.
>>>>>
>>>>> *Fix:*
>>>>> Major changes done for condition of emojis in JNI. Albeit 
>>>>> rendering is
>>>>> not yet supported, they will appear as blank “Missing font” notation.
>>>>> Also, added debug point in case of issue with glyph arrises.
>>>>>
>>>>> With Regards,
>>>>> Avik Niyogi
>>>>
>>>
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160317/172e6f54/attachment.html>