<Swing Dev> Review Request of 8148555: [macosx] An uncaught exception was raised entering Emoji into JTextArea

[Avik Niyogi]

Hi Sergey,
I have tested the test cases as mentioned.
1) They are not related to the current fix
2) ScreenMenuBarInputTwice.java issue is not reproducible.
3) There is a test bug in ActionListenerCalledTwiceTest.java, hence a new test case called ScreenMenuBarInputTwice.java 
was created to encompass actual expectations from Java on OS X as per native behaviour.

Please review my current fix as available in the mail trail. Thank you in advance.

With Regards,
Avik Niyogi


> On 14-Mar-2016, at 6:48 pm, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> 
> Hi, Avik.
> Can you please take a look to these two tests before fixing this bug:
> 
> TEST: javax/swing/JMenuItem/8139169/ScreenMenuBarInputTwice.java
> --------------------------------------------------
> TEST: javax/swing/JMenuItem/ActionListenerCalledTwice/ActionListenerCalledTwiceTest.java
> 
> I remember they passed on jdk8, but it seems we have a regression in jdk9 and both of them fail.
> 
> On 14.03.16 8:05, Avik Niyogi wrote:
>> Hi All,
>> A gentle reminder, please review my code changes.
>> 
>> With Regards,
>> Avik Niyogi
>>> On 08-Mar-2016, at 9:39 pm, Avik Niyogi <avik.niyogi at oracle.com <mailto:avik.niyogi at oracle.com>
>>> <mailto:avik.niyogi at oracle.com <mailto:avik.niyogi at oracle.com>>> wrote:
>>> 
>>> Hi All,
>>> 
>>> Kindly review the bug fix for JDK 9.
>>> 
>>> *Bug:*
>>> 
>>> _https://bugs.openjdk.java.net/browse/JDK-8148555_ <https://bugs.openjdk.java.net/browse/JDK-8148555_>
>>> _
>>> _
>>> *Webrev:*
>>> 
>>> _http://cr.openjdk.java.net/~aniyogi/8148555/webrev.00/_
>>> 
>>> *Issue:*
>>> Emoji selection in Character Viewer was causing exception in JNI
>>> 
>>> *Cause:*
>>> Emojis are considered to be of different class type (namely,
>>> NSConcreteMutableAttributedString) from NSString which other
>>> characters are because of a surrogate pair for them.
>>> 
>>> *Fix:*
>>> Major changes done for condition of emojis in JNI. Albeit rendering is
>>> not yet supported, they will appear as blank “Missing font” notation.
>>> Also, added debug point in case of issue with glyph arrises.
>>> 
>>> With Regards,
>>> Avik Niyogi
>> 
> 
> 
> -- 
> Best regards, Sergey.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160318/a53ee1ad/attachment.html>