<Swing Dev> RfR, JDK-8145228 , Java Access Bridge, getAccessibleStatesStringFromContext doesn't wrap the call to getAccessibleRole

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Fri Mar 18 08:51:23 UTC 2016


The fix looks good to me.

Thanks,
Alexandr.

On 18/03/16 01:22, Pete Brunet wrote:
> Thanks Alexandr, I fixed that here:
> http://cr.openjdk.java.net/~ptbrunet/JDK-8145228/webrev.01/
>
> Pete
>
> On 3/14/16 7:23 AM, Alexander Scherbatiy wrote:
>>
>>   The fix looks good to me.
>>
>>   There is a small comment about code formatting.
>>   I believe that according to the new Java Style Guidelines where
>> should not be a space between open brackets "( ()"
>> http://cr.openjdk.java.net/~alundblad/styleguide/#toc-lambda-expressions
>>
>>   Thanks,
>>   Alexandr.
>>
>> On 3/1/2016 2:18 AM, Renaud Paquay wrote:
>>> looks good to me -- assuming it is ok to use lambda syntax in this
>>> file, the rest of the file still uses the anonymous inner class syntax.
>>>
>>> On Mon, Feb 29, 2016 at 12:35 PM, Pete Brunet
>>> <peter.brunet at oracle.com <mailto:peter.brunet at oracle.com>> wrote:
>>>
>>>      Please review this change which runs code on the EDT like it
>>>      should have.
>>>
>>>      http://cr.openjdk.java.net/~ptbrunet/JDK-8145228/webrev.00/
>>>      <http://cr.openjdk.java.net/%7Eptbrunet/JDK-8145228/webrev.00/>
>>>
>>>




More information about the swing-dev mailing list