<Swing Dev> [9] Review request for 8152159 LabelUI is not updated for TitledBorder

[Semyon Sadetsky]

Looks good.

--Semyon

On 3/18/2016 9:29 PM, Alexander Scherbatiy wrote:
> On 18/03/16 19:40, Semyon Sadetsky wrote:
>> Hi Alexander,
>>
>> Maybe it would be more optimal to update UI in a property change 
>> listener added to the UIManager?
>>
>>     public void propertyChange(PropertyChangeEvent e) {
>>         if ("lookAndFeel" == e.getPropertyName()) {
>>               label.updateUI();
>>         }
>>     }
>>
>
>   Thank you for the review.
>
>   Could you review the updated fix:
> http://cr.openjdk.java.net/~alexsch/8152159/webrev.01/
>
>   - property change listener is used to get a notification bot L&F or 
> LabelUI change
>   - the test is updated to check the LabelUI change
>
>  Thanks,
>  Alexandr.
>> --Semyon
>>
>> On 3/18/2016 11:58 AM, Alexander Scherbatiy wrote:
>>>
>>> Hello,
>>>
>>> Could you review the fix:
>>>   bug: https://bugs.openjdk.java.net/browse/JDK-8152159
>>>   webrev: http://cr.openjdk.java.net/~alexsch/8152159/webrev.00
>>>
>>>
>>>   The TitledBorder label is only used for painting and does not 
>>> belong  to any component hierarchy so it is not updated by 
>>> SwingUtilities.updateComponentTreeUI() method.
>>>   The fix updates the  TitledBorder label UI when the label is 
>>> requested.
>>>
>>>   Thanks,
>>>   Alexandr.
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160321/c510eaf6/attachment.html>