<Swing Dev> [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

[Avik Niyogi]

Hi Rajeev,

The fix looks fine to me.

With Regards,
Avik Niyogi

-----Original Message-----
From: Rajeev Chamyal 
Sent: 23 March 2016 14:45
To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
Subject: RE: <Swing Dev> [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

Hello Sergey,

I had found below link about pre tag which states A P tag is strictly not permitted inside PRE, but if a browser encounters one, it should treat it as two newlines.
http://www.htmlhelp.com/reference/wilbur/block/pre.html <http://www.htmlhelp.com/reference/wilbur/block/pre.html> 

Regards,
Rajeev Chamyal

-----Original Message-----
From: Sergey Bylokhov
Sent: 22 March 2016 21:58
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
Subject: Re: <Swing Dev> [9] Review request for JDK-8150225 api/javax_swing/text/AbstractWriter/index_indent failed

Looks fine to me. But I am not an expert here. And I wonder why the <p> tag is so specific, can we get the similar issue if some other tags will be used instead?

On 22.03.16 11:35, Rajeev Chamyal wrote:
> Hello All,
> 
> Gentle reminder.
> Please review the fix.
> 
> Bug : https://bugs.openjdk.java.net/browse/JDK-8150225 <https://bugs.openjdk.java.net/browse/JDK-8150225>
> Webrev: http://cr.openjdk.java.net/~rchamyal/8150225/webrev.00/ <http://cr.openjdk.java.net/~rchamyal/8150225/webrev.00/>
> 
> Regards,
> Rajeev Chamyal
> 
> -----Original Message-----
> From: Rajeev Chamyal
> Sent: 09 March 2016 15:58
> To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
> Subject: Re: <Swing Dev> [9] Review request for JDK-8150225 
> api/javax_swing/text/AbstractWriter/index_indent failed
> 
> Hello Sergey,
> 
> I have run JCK tests for HTMLWriter and AbstractWriter with this fix and all passed.
> 
> Regards,
> Rajeev Chamyal
> 
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: 09 March 2016 15:54
> To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev at openjdk.java.net <mailto:swing-dev at openjdk.java.net>
> Subject: Re: <Swing Dev> [9] Review request for JDK-8150225 
> api/javax_swing/text/AbstractWriter/index_indent failed
> 
> Hi, Rajeev.
> Please confirm that there are no new issues in the jck after this fix.
> 
> On 09.03.16 12:18, Rajeev Chamyal wrote:
>> Hello All,
>> 
>> Please review the following fix for Jdk9:
>> 
>> Bug : https://bugs.openjdk.java.net/browse/JDK-8150225 <https://bugs.openjdk.java.net/browse/JDK-8150225>
>> 
>> Webrev: http://cr.openjdk.java.net/~rchamyal/8150225/webrev.00/ <http://cr.openjdk.java.net/~rchamyal/8150225/webrev.00/>
>> <http://cr.openjdk.java.net/~rchamyal/8146276/webrev.00/ <http://cr.openjdk.java.net/~rchamyal/8146276/webrev.00/>>
>> 
>> Issue : JCK conformance test failed due to fix for bug JDK-7104635
>> 
>> Fix: Reverted the fix for JDK-7104635 and added a new method in 
>> HTMLWriter.java to check if P tag is within Pre tag.
>> 
>> Decrement indentation is skipped if P tag is with a Pre tag.
>> 
>> Regards,
>> 
>> Rajeev Chamyal
>> 
> 
> 
> --
> Best regards, Sergey.
> 


--
Best regards, Sergey.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160324/a02f327a/attachment.html>