<Swing Dev> [9] Review request for 8146301: Enter key does not work in a deserialized JFileChooser

Phil Race philip.race at oracle.com
Tue Mar 29 19:15:46 UTC 2016


The fix looks fine to me and I agree the OS X problem is a distinct one.

-phil.

On 03/21/2016 11:05 AM, Semyon Sadetsky wrote:
> On 3/21/2016 8:09 PM, Sergey Bylokhov wrote:
>> On 21.03.16 19:46, Semyon Sadetsky wrote:
>>> yes. This a generic code issue.
>>
>> It is failed on OSX even after the fix, please double check.
> This problem is unrelated to the current issue. I have filed a 
> separate bug: https://bugs.openjdk.java.net/browse/JDK-8152332.
>>
>>>
>>> On 3/17/2016 6:55 PM, Sergey Bylokhov wrote:
>>>> Does the test is passed on all platforms?
>>>>
>>>> On 17.03.16 17:37, Semyon Sadetsky wrote:
>>>>> Hello,
>>>>>
>>>>> Please review fix for JDK9:
>>>>>
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8146301
>>>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8146301/webrev.00/
>>>>>
>>>>> This is a regression of JDK-8021253 in which explicit setting the
>>>>> default button was moved to the hierarchy listener but this listener
>>>>> disappears after serialization/deserialization cycle because it is 
>>>>> not
>>>>> serializable. The solution is to make it serializable.
>>>>>
>>>>> --Semyon
>>>>
>>>>
>>>
>>
>>
>




More information about the swing-dev mailing list