<Swing Dev> Review Request JDK-6897701 : In Nimbus Disabled Menus and Menu Items don't look disabled

[Alexander Scherbatiy]

On 30/03/16 16:02, Prem Balakrishnan wrote:
>
> Hi*,*
>
> Please review fix for JDK9,
>
> *Bug:*https://bugs.openjdk.java.net/browse/JDK-6897701
>
> *Webrev:*http://cr.openjdk.java.net/~arapte/prem/6897701/webrev.00/ 
> <http://cr.openjdk.java.net/%7Earapte/prem/6897701/webrev.00/>
>
> *Issue:*
>
> In Nimbus Disabled Menus and Menu Items don't look disabled
>
> *Cause:*
>
> For JMenu and JMenuItem, Developer specified TEXT_FOREGROUND color was 
> set even when they were Disabled.
>
> (Instead of setting Color for the State)
>
> *Fix:*
>
> When JMenu and JMenuItem is disabled, Color for the State is used.
>
> *Test: *Manual Test(since visual validation is required)
>

   - if it is a new test the 1999 year should be removed
   - it is better to use public 
javax.swing.plaf.nimbus.NimbusLookAndFeel in the test instead of 
internal com.sun.java.swing.plaf.nimbus
   - is it possible to draw the menu and menu item to a buffered image 
and check its color to make the test automated?

   Thanks,
   Alexandr.
>
> **
>
> Regards,
> Prem
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160330/f6f31fe5/attachment.html>