<Swing Dev> Review Request JDK-8153056 : 8152647(duplicate of 6439354) Manual Test always passes

[Alexander Scherbatiy]

On 31/03/16 14:59, Prem Balakrishnan wrote:
>
> Hi Alexander,
>
> Thankyou for the review.
>
> I agree with what you said ,jtreg  does not wait for new created JFrame.
>
> Executed test on :
>
> Jtreg version: 4.2.0 and 4.1 , facing same issue, even without 
> user/tester validating the output test status shows passed.
>

   It looks like jtreg does not wait for UI closing for manual main tests.
   May be it is better to use CountDownLatch in this case? It least 
there will not be necessary to distinguish InterruptedException 
generated by program of by other reasons.

  Thanks,
  Alexandr.
>
> Hence test enhanced to overcome the above scenario.
>
> Regards,
>
> Prem
>
> *From:*Alexander Scherbatiy
> *Sent:* Wednesday, March 30, 2016 10:40 PM
> *To:* Prem Balakrishnan; Sergey Bylokhov; Semyon Sadetsky; Rajeev 
> Chamyal; swing-dev at openjdk.java.net
> *Subject:* Re: Review Request JDK-8153056 : 8152647(duplicate of 
> 6439354) Manual Test always passes
>
> On 30/03/16 16:08, Prem Balakrishnan wrote:
>
> Hi*,*
>
> Please review fix for JDK9,
>
> *Bug:*https://bugs.openjdk.java.net/browse/JDK-8153056
>
> *Webrev:*http://cr.openjdk.java.net/~arapte/prem/8153056/webrev.00/ 
> <http://cr.openjdk.java.net/%7Earapte/prem/8153056/webrev.00/>
>
> *Issue:*
>
> 8152647(duplicate of 6439354) Manual Test always passes
>
> *Fix:*
>
> Enhanced Test(with Pass, Fail and Timeout)
>
>
>    It does not look as issue in the test but rather as jtreg does not 
> wait for new created JFrame.
>    Could you run the test without the fix with previous version of 
> jtreg? Is the JFrame is shown in this case?
>
>   Thanks,
>   Alexandr.
>
> Regards,
> Prem
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20160331/4a56ca01/attachment.html>