<Swing Dev> [9] Review request for JDK-8152981 Double icons with JMenuItem setHorizontalTextPosition on Win 10

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Wed May 4 14:05:26 UTC 2016


   The fix looks good to me.

   Thanks,
   Alexandr,

On 5/3/2016 3:08 PM, Rajeev Chamyal wrote:
>
> Hello All,
>
> Please review the below webrev.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8152981
>
> Webrev : http://cr.openjdk.java.net/~rchamyal/8152981/webrev.00/ 
> <http://cr.openjdk.java.net/%7Erchamyal/8152981/webrev.00/>
>
> Issue : Setting horizontal text position on a menuItem with icon 
> results in Icon appearing twice on menuItem.
>
> Cause: When HorizontalTextPosition is set to LEFT/CENTER on MenuItem 
> with an Icon, MenuItemUI defaults are not updated to set correct 
> columnlayout .
>
> Which results in setting of check Icon on menuItem and 2 icons are 
> shown on MenuItem.
>
> Fix : installing the UI defaults again if HorizontalTextPosition is 
> set on MenuItem.
>
> Regards,
>
> Rajeev Chamyal
>




More information about the swing-dev mailing list