<Swing Dev> [9] Review request for 8156128: Tests for [AWT/Swing] Conditional support for GTK 3 on Linux

Yuri Nesterenko yuri.nesterenko at oracle.com
Fri May 6 07:22:36 UTC 2016


Hi Phil,

yes, thank you. I've added a simpler black box test
for both Linux and Solaris just verifying that
neither of the flag values (well, of 2 and 3) prevents
GTK LaF initialization. Here we don't try to find which version
of the library is actually loaded.

Please see:
http://cr.openjdk.java.net/~yan/8156128/webrev.01/

Thanks,
-yan

On 05/05/2016 08:26 PM, Phil Race wrote:
>>  30 #   @requires os.family == "linux"
>
> That and the test is very linux centric. Does it need to run on Solaris
> too ?
> Whilst that may only have gtk2 (not sure about S12) we should still test.
>
> -phil.
>
> On 05/05/2016 07:23 AM, Yuri Nesterenko wrote:
>> Colleagues,
>>
>> could you please review the tests for the new jdk.gtk.version property?
>>
>> Webrev is http://cr.openjdk.java.net/~yan/8156128/webrev.00/
>> CR is https://bugs.openjdk.java.net/browse/JDK-8156128
>>
>> A couple of interesting scenarios would require some system preparation
>> (read: hacks) and are not intended for the regular use.
>> See https://bugs.openjdk.java.net/browse/JDK-8156121 filed
>> after one of such special runs.
>>
>> Thanks,
>> -yan
>




More information about the swing-dev mailing list